Skip to content
This repository has been archived by the owner on Sep 22, 2022. It is now read-only.

update docker actions and add arm64 image #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jstewmon
Copy link

I used the intermediate commits to test this on my local branch. I didn't rebase them out to "show my work" in the PR, but I'm happy to rebase them out if you like.

Here's the action run from my fork:
https://github.com/jstewmon/grpc-wiremock/actions/runs/2235639897

Here's the resulting docker image tag on Docker Hub:
https://hub.docker.com/layers/grpc-wiremock/jstewmon/grpc-wiremock/arm64/images/sha256-41202879efb285cce147179157f5bf1bc87da3f88b371f2c5bbe3f4772ccb965?context=explore

In addition to producing both amd64 and arm64 images, I added a major.minor image tag.

closes #34

@neiljohari
Copy link

Hey @Adven27, wanted to bump this PR to see if you had a chance to review it

We've been successfully using grpc-wiremock (thank you for your work on this), but some of us are starting to use M1 machines and find the x86 emulation to be brutally inefficient. The image that this PR produces seems to solve the issue 😄

context: .
platforms: linux/amd64,linux/arm64
push: ${{ github.event_name != 'release' }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm should this be:

Suggested change
push: ${{ github.event_name != 'release' }}
push: ${{ github.event_name == 'release' }}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build multiarch image for Mac M1 support
2 participants